Hi
Not sure if this is the right way to report bugs, but i have been tracing through the code for your PortalLayout structure in an effort to get PortalLayout.addPortlet(...) working with an EditPane and EditNodes retrofitted onto subclassed PortalLayout, PortalColumn, PortalRow and Portlet structures which we are using, and encountered an execution path which breaks:
In PortalColumn.addPortletToExistingRow(), you have a line
this.addNode(portlet.editNode, this.editNode, rows.length);
which i think should be
this.editContext.addNode(portlet.editNode, this.editNode, rows.length);
This was the case in the 2014-05-27 Enterprise nightly build which we are currently using, and is still the case in the latest nightly build (2014-06-04 at time of writing).
I suspect that if you have done tests for this code that they have failed to cover this execution path because (1) PortalColumn doesn't have an addNode method, and (2) everywhere else you use addNode it is applied to an editContext.
Please inspect and fix if you think it is appropriate to do so.
It certainly seems to work better for me when i apply this change , but i don't want to have to override this method just because of something that might need fixing on your side.
Not sure if this is the right way to report bugs, but i have been tracing through the code for your PortalLayout structure in an effort to get PortalLayout.addPortlet(...) working with an EditPane and EditNodes retrofitted onto subclassed PortalLayout, PortalColumn, PortalRow and Portlet structures which we are using, and encountered an execution path which breaks:
In PortalColumn.addPortletToExistingRow(), you have a line
this.addNode(portlet.editNode, this.editNode, rows.length);
which i think should be
this.editContext.addNode(portlet.editNode, this.editNode, rows.length);
This was the case in the 2014-05-27 Enterprise nightly build which we are currently using, and is still the case in the latest nightly build (2014-06-04 at time of writing).
I suspect that if you have done tests for this code that they have failed to cover this execution path because (1) PortalColumn doesn't have an addNode method, and (2) everywhere else you use addNode it is applied to an editContext.
Please inspect and fix if you think it is appropriate to do so.
It certainly seems to work better for me when i apply this change , but i don't want to have to override this method just because of something that might need fixing on your side.